Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(frontend): Nav and Page Spacing #704

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

jenny-s51
Copy link
Contributor

Description

To achieve proper page alignment, the Page component requires the sidebar prop to render the PageSidebar component. The sidebar component is added to App.tsx and is closed by default.

Before:
Screenshot 2025-01-16 at 11 27 15 AM

After:
Screenshot 2025-01-16 at 11 26 58 AM

How Has This Been Tested?

Simulate Integrated mode by commenting out instances of isStandalone() in App.tsx.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Jenny <[email protected]>

update margin-top to 24px
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! There is a slight extra margin the right of the sidebar in standalone mode, but for now I think we are good with how it looks for Kubeflow.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Jan 16, 2025

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 16, 2025
@google-oss-prow google-oss-prow bot merged commit a7af392 into kubeflow:main Jan 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants