Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve username logic and add navbar elements #641

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

lucferbux
Copy link
Contributor

@lucferbux lucferbux commented Dec 11, 2024

Description

In this PR:

  • Support username and isAdmin based on feat(bff): user info endpoint #630
  • Add elements in navbar to mimic Kubeflow Central Dashboard
  • Removes part of the TODOs we need to fix before the release
Screenshot 2024-12-11 at 13 38 57

How Has This Been Tested?

  1. In PoC mode and mock mode
  2. Log in
  3. Check that you can communicate with the backend

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@lucferbux lucferbux force-pushed the rhoaieng-16881-1 branch 2 times, most recently from e7e3e80 to 29b0519 Compare December 11, 2024 14:23
@google-oss-prow google-oss-prow bot added size/XXL and removed size/L labels Dec 11, 2024
Signed-off-by: lucferbux <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Dec 13, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 13, 2024
@google-oss-prow google-oss-prow bot merged commit 2fb4d26 into kubeflow:main Dec 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants