-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve username logic and add navbar elements #641
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
requested review from
andreyvelich,
ederign and
Griffin-Sullivan
December 11, 2024 12:57
lucferbux
force-pushed
the
rhoaieng-16881-1
branch
2 times, most recently
from
December 11, 2024 14:23
e7e3e80
to
29b0519
Compare
Signed-off-by: lucferbux <[email protected]>
Signed-off-by: lucferbux <[email protected]>
Signed-off-by: lucferbux <[email protected]>
Signed-off-by: lucferbux <[email protected]>
lucferbux
force-pushed
the
rhoaieng-16881-1
branch
from
December 11, 2024 14:24
29b0519
to
8c54dde
Compare
lucferbux
force-pushed
the
rhoaieng-16881-1
branch
from
December 13, 2024 00:13
0364431
to
e820f42
Compare
Signed-off-by: lucferbux <[email protected]>
lucferbux
force-pushed
the
rhoaieng-16881-1
branch
from
December 13, 2024 00:19
e820f42
to
5079f05
Compare
ederign
approved these changes
Dec 13, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR:
username
andisAdmin
based on feat(bff): user info endpoint #630How Has This Been Tested?
Merge criteria:
DCO
check)If you have UI changes