-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp docs & codebase #542
Conversation
256d856
to
974c228
Compare
f5e4bc2
to
96c6382
Compare
Signed-off-by: lucferbux <[email protected]>
Signed-off-by: lucferbux <[email protected]>
Signed-off-by: lucferbux <[email protected]>
Signed-off-by: lucferbux <[email protected]>
96c6382
to
36ee5de
Compare
Co-authored-by: Alex Creasy <[email protected]> Signed-off-by: Lucas Fernandez <[email protected]>
Signed-off-by: lucferbux <[email protected]>
df30e54
to
23be744
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lucas great work! Worked like magic:
Suggested future improvements
- on make dev-bff: be able to configure the port and mock options
- small typo on deploykindcluster.sh L 53
- create a way to delete deployment of a cluster and rebuild and redeploy.
But all of those can be done in FUP PR's. I'll merge this because I'll make a FUP PR on top of it!.
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, rareddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Revamp docs to speed up onboarding and a add some automated scripts
How Has This Been Tested?
Merge criteria:
DCO
check)If you have UI changes