Fixing slog.Logger.Error arg err should be a string or a slog.Attr (possible missing key or value)

[ederign]

Description

On go 23, this error occurs:

internal/mocks/k8s_mock.go:53:52: slog.Logger.Error arg "err" should be a string or a slog.Attr (possible missing key or value)
internal/mocks/k8s_mock.go:60:54: slog.Logger.Error arg "err" should be a string or a slog.Attr (possible missing key or value)
internal/mocks/k8s_mock.go:67:40: slog.Logger.Error arg "err" should be a string or a slog.Attr (possible missing key or value)

How Has This Been Tested?

Ran the BFF and ran the FE.

Merge criteria:

• All the commits have been signed-off (To pass the DCO check)

• The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work.
• Code changes follow the kubeflow contribution guidelines.

[Griffin-Sullivan]

Should we update the go.mod version or add documentation about what version of go to develop with?

[ederign]

@Griffin-Sullivan, that is indeed one of the option or we would stay with our:

https://github.com/kubeflow/model-registry/tree/main/clients/ui/bff#dependencies

Dependencies
Go >= 1.22.2

I would prefer to keep using 1.22 so as not to be 'too far' ahead from https://github.com/kubeflow/model-registry/blob/main/go.mod#L3 and keep this PR with the purpose of 'fixes built in 1.23.x'

But I'm happy with either of them! :)

[alexcreasy]

Yeah I say we stick close to the go version used in the rest of the project. We can decide on docs separately, I've tested and it works with 1.23 so lgtm

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• clients/ui/OWNERS [alexcreasy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alexcreasy]

/lgtm