-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linearized composed api #50
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
7f9b830
to
cccd66a
Compare
Signed-off-by: Andrea Peruffo <[email protected]>
cccd66a
to
e0e8921
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have contributed coordination with team and @andreaTP on this topic, this linearization of the openapi as Andrea mentions not only make it easier to be consumed by code-generators, but in the experience it's also easy to manage, while preserving the original principle of DRY: as can be seen in the generated Go model files, structure is preserved.
/lgtm
I only wish there was a prow command for special appreciation too :)
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andreaTP The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Andrea Peruffo <[email protected]>
d250e73
to
85a062b
Compare
Signed-off-by: Matteo Mortari <[email protected]>
I'm going to hold this one a bit more as I've requested specific feedback, also in relation to:
/hold |
[pull] main from kubeflow:main
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
With the MR python client rebase on REST (#152) this appears to no longer be needed, so we're going to close this. For more information: #181 Thank you for contributions, we truly appreciated your commitment and everyone's direct and indirect work to rebase the MR python client on REST. |
Flattened out the OpenAPI description, now anything that starts "With" contains properties, and everything else is a composition of those things.
Description
This change makes it easier for code generators to deal with the spec, both Kiota and OpenApi generator (Go server) are now behaving well.
Like before, even in this solution, there is no repetition of properties.
Please note that the Go Server generated code is completely compatible with the previous one.
How Has This Been Tested?
Tests in CI.
Merge criteria: