Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query param might be empty string value #49

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

tarilabs
Copy link
Member

@tarilabs tarilabs commented Mar 21, 2024

...handle gin-generated code by openapi-codegen internally, so to make properly string ptr semantic as expected by core lib, as a query param might not even be passed during requests

many thanks to @devguyio for reporting.

Description

How Has This Been Tested?

gmake test
robot test/robot/UserStory.robot

both passing.

Also, manually tested with:

curl -X 'GET' \
  'http://localhost:8080/api/model_registry/v1alpha3/model_artifact?name=v8-model&parentResourceId=17' \
  -H 'accept: application/json'
{"artifactType":"model-artifact","createTimeSinceEpoch":"1711018490528","customProperties":{},"description":"Model artifact for MNIST v8","id":"9","lastUpdateTimeSinceEpoch":"1711018490528","modelFormatName":"onnx","modelFormatVersion":"1","name":"v8-model","state":"UNKNOWN","storageKey":"aws-connection-models","storagePath":"mnist/v8","uri":"s3://models/mnist/v8/mnist-8.onnx"}

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

...handle gin-generated code by openapi-codegen internally,
so to make propert string ptr semantic as expected by core lib,
as a query param might not even be passed during requests

Signed-off-by: Matteo Mortari <[email protected]>
Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rareddy, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2245b4b into kubeflow:main Mar 25, 2024
10 checks passed
rkubis pushed a commit to rkubis/model-registry that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants