Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled text color on DescriptionListDescription #434

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

Griffin-Sullivan
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan commented Sep 27, 2024

Description

In my last PR I was using text.iconColorSubtle to get around the disabled color being to low of a color ratio on a white background. It was causing our a11y testing to fail. Turns out you don't need to pass color contrast ratios on disabled elements so conditionally adding the aria-disabled attribute will cause the tests to pass.

The color change is probably not noticeable enough to anyone but can add an image if requested.

How Has This Been Tested?

Running cypress mock tests

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Ok this is great, I would imagine this is gonna happen again soon, we should track this and make sure we port it in other places.

Copy link

@lucferbux: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Ok this is great, I would imagine this is gonna happen again soon, we should track this and make sure we port it in other places.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Griffin-Sullivan
Copy link
Contributor Author

@lucferbux I added a comment to the PF6 SPIKE so people will be aware when swapping to PF6.

Copy link
Member

@ederign ederign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1389f19 into kubeflow:main Sep 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants