-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Register Model and Register Model Version form #431
Conversation
b35bdc7
to
5b367da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small fixes. Looks good to me otherwise.
clients/ui/frontend/src/app/components/pf-overrides/FormSection.scss
Outdated
Show resolved
Hide resolved
clients/ui/frontend/src/app/components/pf-overrides/FormSection.tsx
Outdated
Show resolved
Hide resolved
clients/ui/frontend/src/app/components/pf-overrides/FormSection.tsx
Outdated
Show resolved
Hide resolved
clients/ui/frontend/src/app/pages/modelRegistry/screens/RegisterModel/utils.ts
Outdated
Show resolved
Hide resolved
5b367da
to
77cc610
Compare
Signed-off-by: lucferbux <[email protected]>
77cc610
to
1a94525
Compare
Ooook, everything addresed @Griffin-Sullivan |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, Griffin-Sullivan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Description
Register New Model
Register New Version
How Has This Been Tested?
Test coverage will be added in a follow up PR since there are some reviews to be done with the current codebase
Merge criteria:
DCO
check)If you have UI changes