Implements pagination support for GetAll style endpoints

[alexcreasy]

Description

Implements pagination for the following endpoints:

• GET /v1/model_registry/{model_registry_id}/registered_models
• GET /v1/model_registry/{model_registry_id}/registered_models/{registered_model_id}/versions
• GET /api/v1/model_registry/{model_registry_id}/model_versions/{model_version_id}/artifacts

How Has This Been Tested?

Test Env Setup

1. Run MR using kind locally and run local BFF with mocked k8s client and live MR client:

make run PORT=4000 MOCK_K8S_CLIENT=true MOCK_MR_CLIENT=false

2. Seed MR with some test data to work with:

curl -i -X POST "http://localhost:4000/api/v1/model_registry/model-registry/registered_models" \
     -H "Content-Type: application/json" \
     -d '{ "data": {
  "customProperties": {
    "my-label9": {
      "metadataType": "MetadataStringValue",
      "string_value": "val"
    }
  },
  "description": "bella description",
  "externalId": "9927",
  "name": "bella",
  "owner": "eder",
  "state": "LIVE"
}}'

curl -i -X POST "http://localhost:4000/api/v1/model_registry/model-registry/registered_models" \
     -H "Content-Type: application/json" \
     -d '{ "data": {
  "customProperties": {
    "my-label9": {
      "metadataType": "MetadataStringValue",
      "string_value": "val"
    }
  },
  "description": "other description",
  "externalId": "9928",
  "name": "other",
  "owner": "eder",
  "state": "LIVE"
}}'

Test Procedure

1. Get all registered models

curl -i "http://localhost:4000/api/v1/model_registry/model-registry/registered_models"

2. Verify there are 2 registered models returned.
3. Get registered models with pageSize of 1.

curl -i "http://localhost:4000/api/v1/model_registry/model-registry/registered_models?pageSize=1"

4. Verify one model is returned, pageSize = 1 and size = 1 and that nextPageToken is not empty.
5. Get registered models with pageSize of 1 and nextPageToken.

curl -i "http://localhost:4000/api/v1/model_registry/model-registry/registered_models?pageSize=1&nextPageToken=CAEQARoCCAE"

6. Verify the second model is shown on the second page (NOTE: use the nextPageToken from the previous step)
7. Get registered models ordered by last created time in descending order

curl -i "http://localhost:4000/api/v1/model_registry/model-registry/registered_models?orderBy=LAST_UPDATE_TIME&sortOrder=DESC"

8. Verify results are ordered correctly.
9. Repeat stage 7 but change order to ASC and verify they are reversed.

Merge criteria:

• All the commits have been signed-off (To pass the DCO check)

• The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work.
• Code changes follow the kubeflow contribution guidelines.

If you have UI changes

• The developer has added tests or explained why testing cannot be added.
• Included any necessary screenshots or gifs if it was a UI change.
• Verify that UI/UX changes conform the UX guidelines for Kubeflow.

[ederign]

@alexcreasy thanks for the PR. The code looks OK, but could you please add some samples in our readme of curl calls with pagination for those endpoints?

[Griffin-Sullivan]

@alexcreasy you'll need to rebase so you can run the linter locally for the BFF

[alexcreasy]

I copied the definitions here off the MR OpenAPI spec.

[alexcreasy]

@ederign when you get a chance could you re-review and merge if you're happy? thanks :)

[Griffin-Sullivan]

Tested locally and everything works as expected. Nice work!

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• clients/ui/OWNERS [ederign]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ederign]

/lgtm