feat(docs): add kind - ingress instructions to deploy model registry #410
Conversation
Signed-off-by: Alessio Pragliola <[email protected]>
Signed-off-by: Alessio Pragliola <[email protected]>
google-oss-prow
bot
requested review from
andreyvelich,
tarilabs and
zijianjoy
There was a problem hiding this comment.
Thank you @Al-Pragliola ; some small considerations below: wdyt?
Overall,
/lgtm
| ### Ingress guide | ||
|
|
||
| Follow the [Ingress guide](docs/mr_kind_deploy_ingress.md) to set up the Ingress controller and deploy the Model Registry on the cluster. |
There was a problem hiding this comment.
I would add as an alternative the manual port-forward, analogous as what we're doing here:
model-registry/.github/workflows/build-image-pr.yml
Lines 81 to 85 in dde9afb
ie this way people would have 2 options to choose based on their likings:
- ingress setup, as you're showing
- manual port forward
wdyt?
There was a problem hiding this comment.
yep, makes totally sense
Co-authored-by: Matteo Mortari <[email protected]> Signed-off-by: Alessio Pragliola <[email protected]>
Signed-off-by: Alessio Pragliola <[email protected]> Co-authored-by: Matteo Mortari <[email protected]>
Al-Pragliola
force-pushed
the
Al-Pragliola/add-ingress-instructions
branch
from
9f461db to
31f0182
Compare
Co-authored-by: Matteo Mortari <[email protected]> Signed-off-by: Alessio Pragliola <[email protected]>
There was a problem hiding this comment.
awesome, thank you @Al-Pragliola , this will help to showcase options for local testing to contributors in an easy/easier way!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
I have added a small guide to deploy model registry on a kind cluster using an ingress instead of port-forward, hoping people will find it useful for local testing
How Has This Been Tested?
followed locally the steps described in the guide
Merge criteria:
All the commits have been signed-off (To pass the
DCOcheck)The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work.
Code changes follow the kubeflow contribution guidelines.