Add views for Model Versions and Model Details #409
Conversation
google-oss-prow
bot
requested review from
alexcreasy,
andreyvelich and
ederign
| }); | ||
|
|
||
| it('Model versions table', () => { | ||
| // TODO: Uncomment when we fix finding dropdown items |
There was a problem hiding this comment.
Note that this test was edited slightly to avoid any dropdown checks
Griffin-Sullivan
force-pushed
the
model-details
branch
from
137087e to
ffaa823
Compare
| <Route | ||
| path={ModelVersionsTab.DETAILS} | ||
| element={<ModelVersions tab={ModelVersionsTab.DETAILS} empty={false} />} | ||
| /> |
There was a problem hiding this comment.
Just to disclose the private conversation, there will be a follow up to add the archive view here.
| isEditing = isAddRow, | ||
| keyValuePair = { key: '', value: '' }, | ||
| deleteProperty = () => Promise.resolve(), | ||
| allExistingKeys, |
There was a problem hiding this comment.
Take a look at the latest version, it seems they've added a new prop to detect if the model is archived: opendatahub-io/odh-dashboard#3206
There was a problem hiding this comment.
That is addressed already in the PR that will follow this one
|
@lucferbux: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Griffin-Sullivan <[email protected]>
Griffin-Sullivan
force-pushed
the
model-details
branch
from
ffaa823 to
7e19ff6
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexcreasy, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Adding all Screens, Components, and Cypress tests for Model details and versions table. I've also added a Jest unit test for some helpers that were added in a previous PR. Also note a small addition to our tsconfig to get around an issue I saw in VS Code.
How Has This Been Tested?
Manually testing the UI in mock mode
Jest and Cypress tests
Merge criteria:
DCOcheck)If you have UI changes