-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAS: add generic artifacts routes #406
Conversation
Signed-off-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @isinyaaa, I left just one comment on the goverter definition as I am not completely sure the result would be the expected one. Other than that, it looks great to me!
Signed-off-by: Isabella do Amaral <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @isinyaaa !!
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you again @isinyaaa
/lgtm
focusing on the Go side, anything 👀 worth noting @Al-Pragliola ?
I see the new routes and I don't see changes to the path of the existing REST apis, beyond that
if artifact == nil {
return nil, fmt.Errorf("invalid artifact pointer, can't upsert nil: %w", api.ErrBadRequest)
}
so I'm good with merging asap, I just wanted to double-check this understanding
Looks Good To Me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks again @isinyaaa for the great work and everyone else for 👀 on this
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lampajr, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: #369
Description
Implements generic artifact routes as proposed.
There will be a follow-up to add new methods to the Python client as well.
How Has This Been Tested?
Updated unit tests to cover new core methods.
Merge criteria:
DCO
check)If you have UI changes