Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAS: add generic artifacts routes #406

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

isinyaaa
Copy link
Contributor

Closes: #369

Description

Implements generic artifact routes as proposed.

There will be a follow-up to add new methods to the Python client as well.

How Has This Been Tested?

Updated unit tests to cover new core methods.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

patches/type_asserts.patch Outdated Show resolved Hide resolved
Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @isinyaaa, I left just one comment on the goverter definition as I am not completely sure the result would be the expected one. Other than that, it looks great to me!

internal/converter/openapi_reconciler.go Outdated Show resolved Hide resolved
@isinyaaa
Copy link
Contributor Author

I'm so glad all the suggestions so far have cut down the patch size tremendously :) thank you so much @tarilabs @lampajr for the care

@isinyaaa isinyaaa requested a review from lampajr September 23, 2024 13:44
Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isinyaaa !!

/lgtm

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#406 (comment)
+1

thank you again @isinyaaa
/lgtm

focusing on the Go side, anything 👀 worth noting @Al-Pragliola ?

I see the new routes and I don't see changes to the path of the existing REST apis, beyond that

	if artifact == nil {
		return nil, fmt.Errorf("invalid artifact pointer, can't upsert nil: %w", api.ErrBadRequest)
	}

so I'm good with merging asap, I just wanted to double-check this understanding

@Al-Pragliola
Copy link
Contributor

#406 (comment) +1

thank you again @isinyaaa /lgtm

focusing on the Go side, anything 👀 worth noting @Al-Pragliola ?

I see the new routes and I don't see changes to the path of the existing REST apis, beyond that

	if artifact == nil {
		return nil, fmt.Errorf("invalid artifact pointer, can't upsert nil: %w", api.ErrBadRequest)
	}

so I'm good with merging asap, I just wanted to double-check this understanding

Looks Good To Me 👍

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again @isinyaaa for the great work and everyone else for 👀 on this

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lampajr, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0d77878 into kubeflow:main Sep 25, 2024
17 checks passed
@isinyaaa isinyaaa deleted the genart branch September 25, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

standardize artifact API
4 participants