Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: reorder type_asserts.go using Python #404

Closed

Conversation

tarilabs
Copy link
Member

Description

  • restore gen_type_asserts to avoid regex (restores example)
  • use Python for re-ordering without regex

How Has This Been Tested?

change openapi.yaml and make

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

wdyt @isinyaaa ?

- restore gen_type_asserts to avoid regex
- use Python for re-ordering without regex

Signed-off-by: Matteo Mortari <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tarilabs. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs tarilabs force-pushed the tarilabs-20240919-reorderWithPy branch 2 times, most recently from e48aa36 to bf84bb5 Compare September 19, 2024 20:14
@tarilabs tarilabs force-pushed the tarilabs-20240919-reorderWithPy branch from bf84bb5 to 00d1192 Compare September 19, 2024 20:18
@tarilabs
Copy link
Member Author

closing this in favour of #403

@tarilabs tarilabs closed this Sep 20, 2024
@tarilabs tarilabs mentioned this pull request Sep 20, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant