Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py: rename pager limit method to page_size #379

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Py: rename pager limit method to page_size #379

merged 4 commits into from
Sep 12, 2024

Conversation

isinyaaa
Copy link
Contributor

Closes: #357

This should sort out semantics issues.

Description

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@isinyaaa
py: pager: rename limit to page_size
b9e839d 
... to improve semantics.

Closes: kubeflow#357
Signed-off-by: Isabella do Amaral <[email protected]>
@isinyaaa
py: fix custom_props typing issue
37bae47 
Signed-off-by: Isabella do Amaral <[email protected]>
@isinyaaa
py: test pager descending option
3e18fbb 
Signed-off-by: Isabella do Amaral <[email protected]>
tarilabs
tarilabs reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @isinyaaa

/lgtm

and see some potential notes below?

clients/python/tests/test_client.py Show resolved Hide resolved
clients/python/src/model_registry/types/pager.py Show resolved Hide resolved
clients/python/README.md Outdated Show resolved Hide resolved
clients/python/README.md Outdated Show resolved Hide resolved
@google-oss-prow google-oss-prow bot added the lgtm label Sep 12, 2024
@isinyaaa
py: update README with suggestion
6379e2b 
Signed-off-by: Isabella do Amaral <[email protected]>
@google-oss-prow google-oss-prow bot removed the lgtm label Sep 12, 2024
@isinyaaa isinyaaa requested a review from tarilabs September 12, 2024 19:12
tarilabs
tarilabs approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for reflecting the changes @isinyaaa ,

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Sep 12, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 548fb51 into kubeflow:main Sep 12, 2024
15 checks passed
@isinyaaa isinyaaa deleted the push-ttlkrqwnvrnr branch September 12, 2024 20:07
@tarilabs tarilabs mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarilabs tarilabs tarilabs approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@Tomcli Tomcli Awaiting requested review from Tomcli

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@tarilabs tarilabs

Labels
approved Area/MR Python client lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python Client: Issues with limit operation during iteration of models, versions
2 participants
@isinyaaa @tarilabs