Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py: clarify hf install instructions #375

Closed
wants to merge 1 commit into from

Conversation

isinyaaa
Copy link
Contributor

Closes: #370

Description

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

cc: @rareddy @tarilabs

Closes: kubeflow#370

Signed-off-by: Isabella do Amaral <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ckadner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs
Copy link
Member

should we go for this in addition to #373 or as an alternative to it? 🤔
asking because I didn't see comments on #373 and noticed this PR now.

@isinyaaa
Copy link
Contributor Author

@tarilabs so sorry for duplicating this, I felt like I had already looked at notifications for the day 🙃 . Could you take the message on the import error to your PR then? closing this one.

@isinyaaa isinyaaa closed this Sep 10, 2024
@isinyaaa isinyaaa deleted the push-lyoomporrrnu branch September 10, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Please clarify how the Model Registry libraries installed for Hugging face
2 participants