Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaffolding for MR view and MR settings #345

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

lucferbux
Copy link
Contributor

Description

Add scaffolding for both Model Registry view and Admin settings
Screenshot 2024-09-04 at 02 03 28
Screenshot 2024-09-04 at 02 03 19

How Has This Been Tested?

No tests added since we still need the API first, will do in a follow up.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@lucferbux lucferbux force-pushed the mod-arch-10679 branch 2 times, most recently from 147757c to e406beb Compare September 4, 2024 20:46
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at any of the design components but everything looks good to me.

@lucferbux lucferbux force-pushed the mod-arch-10679 branch 3 times, most recently from 85d09ce to bf72b78 Compare September 5, 2024 15:49
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Sep 5, 2024

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants