Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sh script compatible with Mac OSX sed #21

Merged

Conversation

tarilabs
Copy link
Member

@lampajr mind trying this on your end on a bare metal linux box, please?

Description

changes script to execute sed differently depending on uname.

How Has This Been Tested?

Run locally with:

gmake FORCE_SERVER_GENERATION=true clean build

Does no longer result in error:

sed: 1: "./internal/server/opena ...": invalid command code .

on Mac OSX.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tarilabs,
That's working for me as well (on Fedora)

OpenAPI server generation completed
/home/alampare/repos/model-registry/bin/goverter gen github.com/kubeflow/model-registry/internal/converter/
go generate ./...
go vet ./...
/home/alampare/repos/model-registry/bin/golangci-lint run main.go
/home/alampare/repos/model-registry/bin/golangci-lint run cmd/... internal/... ./pkg/...
go build

Copy link
Contributor

@isinyaaa isinyaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks Matteo :)

might also be a good opportunity to bring up the shebang fixes I mentioned to you before, wdyt?

@tarilabs
Copy link
Member Author

might also be a good opportunity to bring up the shebang fixes I mentioned to you before, wdyt?

@isinyaaa agree, but given it's different goal (here is sed differences, what you propose is the shebang headers), imo can be another PRs so we keep small-focused PRs going :) feel free to open new one! 🚀

Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isinyaaa, lampajr, rareddy, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rareddy
Copy link
Contributor

rareddy commented Mar 5, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 5, 2024
@google-oss-prow google-oss-prow bot merged commit ece101a into kubeflow:main Mar 5, 2024
9 checks passed
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants