-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make sh script compatible with Mac OSX sed #21
fix: make sh script compatible with Mac OSX sed #21
Conversation
Signed-off-by: Matteo Mortari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tarilabs,
That's working for me as well (on Fedora)
OpenAPI server generation completed
/home/alampare/repos/model-registry/bin/goverter gen github.com/kubeflow/model-registry/internal/converter/
go generate ./...
go vet ./...
/home/alampare/repos/model-registry/bin/golangci-lint run main.go
/home/alampare/repos/model-registry/bin/golangci-lint run cmd/... internal/... ./pkg/...
go build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks Matteo :)
might also be a good opportunity to bring up the shebang fixes I mentioned to you before, wdyt?
@isinyaaa agree, but given it's different goal (here is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isinyaaa, lampajr, rareddy, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@lampajr mind trying this on your end on a bare metal linux box, please?
Description
changes script to execute
sed
differently depending onuname
.How Has This Been Tested?
Run locally with:
Does no longer result in error:
on Mac OSX.
Merge criteria: