Use Recoverer middleware #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the pipeline builds the server upon a committed version, it's never checked. The implementation has been out-of-date so we also update it. Signed-off-by: Isabella Basso do Amaral <[email protected]>
This should help diagnose panics, also tries to deliver 500 to clients. [1]: https://pkg.go.dev/github.com/go-chi/chi/middleware#Recoverer Signed-off-by: Isabella Basso do Amaral <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
isinyaaa
commented
Jul 16, 2024
Comment on lines
80
to
-81
| @if git diff --exit-code --name-only | grep -q "api/openapi/model-registry.yaml" || \ | ||
| git diff --exit-code --name-only | grep -q "api/openapi/model-registry.yaml" || \ |
There was a problem hiding this comment.
As the pipeline builds the server upon a committed version, the server is never checked.
It seems we have also forgotten to update it some time ago, I wonder if there's a better way to test this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recoverer should help diagnose panics, also tries to deliver 500 to clients.
Also force server rebuild on the build action to ensure we're not leaving uncommitted changes.
The implementation has been out-of-date so we also update it.
How Has This Been Tested?
Merge criteria: