Skip to content

Commit

Permalink
implement todo for protoc aarch_64, avoid network:host
Browse files Browse the repository at this point in the history
Signed-off-by: Matteo Mortari <[email protected]>
  • Loading branch information
tarilabs committed Apr 11, 2024
1 parent 395c361 commit e50cd37
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 11 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ endif
# build docker image
.PHONY: image/build
image/build:
${DOCKER} build . -f ${DOCKERFILE} -t ${IMG}:$(IMG_VERSION) --network host
${DOCKER} build . -f ${DOCKERFILE} -t ${IMG}:$(IMG_VERSION)

# push docker image
.PHONY: image/push
Expand Down
11 changes: 2 additions & 9 deletions docker-compose-local.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ services:
image: gcr.io/tfx-oss-public/ml_metadata_store_server:1.14.0
container_name: mlmd-server
ports:
- target: 8080
published: 9090
protocol: tcp
mode: host
- "9090:8080"
environment:
- METADATA_STORE_SERVER_CONFIG_FILE=/tmp/shared/conn_config.pb
volumes:
Expand All @@ -16,13 +13,9 @@ services:
build:
context: .
dockerfile: Dockerfile
network: host
command: ["proxy", "--hostname", "0.0.0.0", "--mlmd-hostname", "mlmd-server", "--mlmd-port", "8080"]
container_name: model-registry
ports:
- target: 8080
published: 8080
protocol: tcp
mode: host
- "8080:8080"
depends_on:
- mlmd-server
4 changes: 3 additions & 1 deletion scripts/install_protoc.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ if [[ "$OSTYPE" == "darwin"* ]]; then
# Mac OSX
OS="osx"
fi
# TODO: support for arm
ARCH="x86_64"
if [[ "$(uname -m)" == "arm"* ]]; then
ARCH="aarch_64"
fi

mkdir -p ${SCRIPT_DIR}/../bin

Expand Down

0 comments on commit e50cd37

Please sign in to comment.