introduce openapi defaults

Signed-off-by: Matteo Mortari <[email protected]>
kubeflow · Feb 22, 2024 · d94f7f4 · d94f7f4
1 parent 2edb456
commit d94f7f4
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 5 deletions.
diff --git a/api/openapi/model-registry.yaml b/api/openapi/model-registry.yaml
@@ -1125,6 +1125,7 @@ components:
         metadataType:
           type: string
           example: MetadataIntValue
+          default: MetadataIntValue
     MetadataDoubleValue:
       description: A double property value.
       type: object
@@ -1138,6 +1139,7 @@ components:
         metadataType:
           type: string
           example: MetadataDoubleValue
+          default: MetadataDoubleValue
     MetadataStringValue:
       description: A string property value.
       type: object
@@ -1150,6 +1152,7 @@ components:
         metadataType:
           type: string
           example: MetadataStringValue
+          default: MetadataStringValue
     MetadataStructValue:
       description: A struct property value.
       type: object
@@ -1163,6 +1166,7 @@ components:
         metadataType:
           type: string
           example: MetadataStructValue
+          default: MetadataStructValue
     MetadataProtoValue:
       description: A proto property value.
       type: object
@@ -1180,6 +1184,7 @@ components:
         metadataType:
           type: string
           example: MetadataProtoValue
+          default: MetadataProtoValue
     MetadataBoolValue:
       description: A bool property value.
       type: object
@@ -1192,6 +1197,7 @@ components:
         metadataType:
           type: string
           example: MetadataBoolValue
+          default: MetadataBoolValue
     BaseResource:
       allOf:
         - $ref: "#/components/schemas/BaseResourceCreate"

diff --git a/internal/converter/mlmd_openapi_converter_util.go b/internal/converter/mlmd_openapi_converter_util.go
@@ -13,23 +13,33 @@ import (
 )
 
 func NewMetadataStringValue(value string) *openapi.MetadataStringValue {
-	return openapi.NewMetadataStringValue(value, "MetadataStringValue")
+	result := openapi.NewMetadataStringValueWithDefaults()
+	result.StringValue = value
+	return result
 }
 
 func NewMetadataBoolValue(value bool) *openapi.MetadataBoolValue {
-	return openapi.NewMetadataBoolValue(value, "MetadataBoolValue")
+	result := openapi.NewMetadataBoolValueWithDefaults()
+	result.BoolValue = value
+	return result
 }
 
 func NewMetadataDoubleValue(value float64) *openapi.MetadataDoubleValue {
-	return openapi.NewMetadataDoubleValue(value, "MetadataDoubleValue")
+	result := openapi.NewMetadataDoubleValueWithDefaults()
+	result.DoubleValue = value
+	return result
 }
 
 func NewMetadataIntValue(value string) *openapi.MetadataIntValue {
-	return openapi.NewMetadataIntValue(value, "MetadataIntValue")
+	result := openapi.NewMetadataIntValueWithDefaults()
+	result.IntValue = value
+	return result
 }
 
 func NewMetadataStructValue(value string) *openapi.MetadataStructValue {
-	return openapi.NewMetadataStructValue(value, "MetadataStructValue")
+	result := openapi.NewMetadataStructValueWithDefaults()
+	result.StructValue = value
+	return result
 }
 
 // MapMLMDCustomProperties maps MLMD custom properties model to OpenAPI one

diff --git a/pkg/openapi/model_metadata_bool_value.go b/pkg/openapi/model_metadata_bool_value.go
diff --git a/pkg/openapi/model_metadata_double_value.go b/pkg/openapi/model_metadata_double_value.go
diff --git a/pkg/openapi/model_metadata_proto_value.go b/pkg/openapi/model_metadata_proto_value.go
diff --git a/pkg/openapi/model_metadata_string_value.go b/pkg/openapi/model_metadata_string_value.go
diff --git a/pkg/openapi/model_metadata_struct_value.go b/pkg/openapi/model_metadata_struct_value.go