Fix http error codes (#125)

* core: rearrange fields to reduce struct size Signed-off-by: Isabella do Amaral <[email protected]> * ignore debug files Signed-off-by: Isabella do Amaral <[email protected]> * api: fix http status error conversion Signed-off-by: Isabella do Amaral <[email protected]> --------- Signed-off-by: Isabella do Amaral <[email protected]>
kubeflow · Jun 4, 2024 · 766ec09 · 766ec09
1 parent e4cdc0a
commit 766ec09
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -11,6 +11,8 @@
 # Test binary, built with `go test -c`
 *.test
 
+__debug*
+
 # Output of the go coverage tool, specifically when used with LiteIDE
 *.out
 

diff --git a/pkg/api/error.go b/pkg/api/error.go
@@ -11,7 +11,7 @@ var (
 )
 
 func ErrToStatus(err error) int {
-	switch err {
+	switch errors.Unwrap(err) {
 	case ErrBadRequest:
 		return http.StatusBadRequest
 	case ErrNotFound:

diff --git a/pkg/core/core.go b/pkg/core/core.go
@@ -20,10 +20,10 @@ import (
 // ModelRegistryService is the core library of the model registry
 type ModelRegistryService struct {
 	mlmdClient  proto.MetadataStoreServiceClient
-	nameConfig  mlmdtypes.MLMDTypeNamesConfig
 	typesMap    map[string]int64
 	mapper      *mapper.Mapper
 	openapiConv *generated.OpenAPIConverterImpl
+	nameConfig  mlmdtypes.MLMDTypeNamesConfig
 }
 
 // NewModelRegistryService creates a new instance of the ModelRegistryService, initializing it with the provided gRPC client connection.
-Original file line number
+Diff line change
@@ Expand Up / @@ -11,6 +11,8 @@ @@
     # Test binary, built with `go test -c`
     *.test
+    __debug*
     # Output of the go coverage tool, specifically when used with LiteIDE
     *.out
@@ Expand Down @@