fixing tests after eslint bump

Signed-off-by: Eder Ignatowicz <[email protected]>
kubeflow · Sep 10, 2024 · 077e67d · 077e67d
1 parent c0b0f3c
commit 077e67d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 12 deletions.
diff --git a/clients/ui/frontend/.eslintrc b/clients/ui/frontend/.eslintrc
@@ -72,7 +72,6 @@
     "no-only-tests/no-only-tests": "error",
     "@typescript-eslint/default-param-last": "error",
     "@typescript-eslint/dot-notation": ["error", { "allowKeywords": true }],
-    "@typescript-eslint/lines-between-class-members": ["error", "always"],
     "@typescript-eslint/method-signature-style": "error",
     "@typescript-eslint/naming-convention": [
       "error",

diff --git a/clients/ui/frontend/src/__tests__/unit/testUtils/hooks.ts b/clients/ui/frontend/src/__tests__/unit/testUtils/hooks.ts
@@ -7,14 +7,8 @@ import {
 } from '@testing-library/react';
 import { queries, Queries } from '@testing-library/dom';
 
-export type BooleanValues<T> = T extends
-  | boolean
-  | number
-  | string
-  | null
-  | undefined
-  // eslint-disable-next-line @typescript-eslint/ban-types
-  | Function
+// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
+export type BooleanValues<T> = T extends boolean | number | null | undefined | Function
   ? boolean | undefined
   : boolean | undefined | { [K in keyof T]?: BooleanValues<T[K]> };
 
@@ -174,7 +168,7 @@ export const createComparativeValue = <T>(source: T, booleanTarget: BooleanValue
 
 const createComparativeValueRecursive = <T>(
   source: unknown,
-  // eslint-disable-next-line @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   booleanTarget: boolean | string | number | Function | BooleanValues<T>,
 ) => {
   if (typeof booleanTarget === 'boolean') {

diff --git a/clients/ui/frontend/src/components/browserStorage/BrowserStorageContext.tsx b/clients/ui/frontend/src/components/browserStorage/BrowserStorageContext.tsx
@@ -102,7 +102,7 @@ export const BrowserStorageContextProvider: React.FC<BrowserStorageContextProvid
       if (parseJSON) {
         try {
           return JSON.parse(value);
-        } catch (e) {
+        } catch {
           /* eslint-disable-next-line no-console */
           console.warn(`Failed to parse storage value "${key}"`);
           return null;
@@ -122,7 +122,7 @@ export const BrowserStorageContextProvider: React.FC<BrowserStorageContextProvid
         setValues((oldValues) => ({ ...oldValues, [storageKey]: storageValue }));
 
         return true;
-      } catch (e) {
+      } catch {
         /* eslint-disable-next-line no-console */
         console.warn(
           'Could not store a value because it was requested to be stringified but was an invalid value for stringification.',