Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace action to setup minikube with medyagh/setup-minikube #2178

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jul 20, 2023

What this PR does / why we need it:
I replaced actions to set up minikube with medyagh/setup-minikube since using manusa/actions-setup-minikube seems to no longer be maintained, and the action doesn't support kubernetes v1.26.

related to: #2177

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@tenzen-y tenzen-y changed the title Replace action to setup minikube with medyagh/setup-minikube WIP: Replace action to setup minikube with medyagh/setup-minikube Jul 20, 2023
@tenzen-y tenzen-y force-pushed the replace-minikube-setup branch 6 times, most recently from 9c10db9 to 623e6bf Compare July 21, 2023 10:37
@andreyvelich andreyvelich mentioned this pull request Jul 26, 2023
6 tasks
@@ -9,9 +9,6 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we require GitHub Token before for our E2Es?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the token is required for the manusa/actions-setup-minikube.

@tenzen-y tenzen-y force-pushed the replace-minikube-setup branch 3 times, most recently from bc037e8 to 109caf8 Compare July 31, 2023 00:15
@tenzen-y tenzen-y changed the title WIP: Replace action to setup minikube with medyagh/setup-minikube Replace action to setup minikube with medyagh/setup-minikube Jul 31, 2023
@tenzen-y
Copy link
Member Author

This PR is ready for review. Also, I confirmed this change is effective for k8s v1.26 at #2177.
/assign @andreyvelich @johnugeorge

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update @tenzen-y!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 31, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, gaocegege, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,gaocegege,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a693848 into kubeflow:master Jul 31, 2023
59 checks passed
@tenzen-y tenzen-y deleted the replace-minikube-setup branch July 31, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants