Skip to content

Commit

Permalink
Add kfpv1 e22 test
Browse files Browse the repository at this point in the history
This action should now run the kubeflow pipeline v1 e2e example.

This required the extension of the `template-e2e-test` to include
parameters to
a) install kfp
b) select the `kubeflow` namespace (instead of default) to run the tests
with.
  • Loading branch information
pre-commit fix Vito Zanotelli committed Sep 12, 2023
1 parent 579546c commit 2254867
Show file tree
Hide file tree
Showing 2 changed files with 56 additions and 2 deletions.
45 changes: 45 additions & 0 deletions .github/workflows/e2e-test-kfpv1.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: E2E Test with pytorch-mnist

on:
pull_request:
paths-ignore:
- "pkg/new-ui/v1beta1/frontend/**"

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

jobs:
e2e:
runs-on: ubuntu-20.04
timeout-minutes: 120
steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Test Env
uses: ./.github/workflows/template-setup-e2e-test
with:
kubernetes-version: ${{ matrix.kubernetes-version }}
python-version: "3.10"

- name: Run e2e test with ${{ matrix.experiments }} experiments
uses: ./.github/workflows/template-e2e-test
with:
experiments: ${{ matrix.experiments }}
training-operator: true
# Comma Delimited
trial-images: kfpv1-metrics-collector
install-kfp: 1.8.1
experiment-namespace: kubeflow

strategy:
fail-fast: false
matrix:
kubernetes-version: ["v1.23.13", "v1.24.7", "v1.25.3"]
# Comma Delimited
experiments:
- "katib-kfp-example-e2e-v1"
13 changes: 11 additions & 2 deletions .github/workflows/template-e2e-test/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@ inputs:
required: false
description: mysql or postgres
default: mysql
install-kfp:
required: false
description: whether kubeflow pipelines is required
as a dependency. If so provide version as string (eg 1.8.1)
default: false
experiment-namespace:
required: false
description: namespace to execute test experiment in
default: default

runs:
using: composite
Expand All @@ -31,8 +40,8 @@ runs:

- name: Setup Katib
shell: bash
run: ./test/e2e/v1beta1/scripts/gh-actions/setup-katib.sh ${{ inputs.katib-ui }} ${{ inputs.training-operator }} ${{ inputs.database-type }}
run: ./test/e2e/v1beta1/scripts/gh-actions/setup-katib.sh ${{ inputs.katib-ui }} ${{ inputs.training-operator }} ${{ inputs.database-type }} ${{ inputs.install-kfp }}

- name: Run E2E Experiment
shell: bash
run: ./test/e2e/v1beta1/scripts/gh-actions/run-e2e-experiment.sh ${{ inputs.experiments }}
run: ./test/e2e/v1beta1/scripts/gh-actions/run-e2e-experiment.sh ${{ inputs.experiments }} ${{ inputs.experiment-namespace }}

0 comments on commit 2254867

Please sign in to comment.