Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: New membership for spolti #640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spolti
Copy link

@spolti spolti commented Jan 10, 2024

PR test output:

❯ pytest test_org_yaml.py
=========================================================== test session starts ============================================================
platform darwin -- Python 3.10.12, pytest-7.4.3, pluggy-1.3.0
rootdir: /Users/fspolti/data/dev/sources/internal-acls/github-orgs
plugins: asyncio-0.20.3, cov-4.1.0, xdist-3.5.0, anyio-4.2.0
asyncio: mode=strict
collected 1 item                                                                                                                           

test_org_yaml.py .                                                                                                                   [100%]

============================================================ 1 passed in 0.13s =============================================================

Copy link

google-cla bot commented Jan 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: spolti
Once this PR has been reviewed and has the lgtm label, please assign neuromage for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @spolti. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rimolive
Copy link
Member

/ok-to-test

@terrytangyuan
Copy link
Member

/lgtm

@rimolive
Copy link
Member

/lgtm

@zijianjoy
Copy link
Contributor

Hello @spolti , would you like to link at least 2 PRs for your contribution in kubeflow ?

@rimolive
Copy link
Member

@zijianjoy Isn't KServe part of Kubeflow? What are acceptable PRs for membership request?

@zijianjoy
Copy link
Contributor

@rimolive That is a tricky question. KServe has its own org now https://github.com/kserve/kserve, so it doesn't seem that this PR is blocking you from continue contributing to KServe.

If @spolti wants to join Kubeflow community, that means they are planning to contribute to one or more projects in Kubeflow org. And it is the reason behind standard procedure : https://github.com/kubeflow/internal-acls#joining-kubeflow-github-organization

@andreyvelich
Copy link
Member

@zijianjoy Should we discuss if we could make an exception for KServe contributors to join the Kubeflow community ?
Since KServe is very title coupled to Kubeflow ecosystem ?
I am happy to discuss this more in one of the upcoming Kubeflow community calls.
cc @jbottum @james-jwu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants