Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposed checklist for docs need for each release #581

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jbottum
Copy link
Contributor

@jbottum jbottum commented Oct 21, 2022

Adding a list of docs that should be reviewed before each release

Adding a list of docs that should be reviewed before each release
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbottum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jbottum
Copy link
Contributor Author

jbottum commented Oct 21, 2022

@DomFleischmann @annajung @kimwnasptd Per our discussion in the Release Team meeting, I have proposed adding this docs checklist to the release handbook. I would appreciate your review.

**Success Criteria:** Documentation for this release completed with minimum following pages updated and a [new version
in the website is cut](https://github.com/kubeflow/kubeflow/blob/master/docs_dev/releasing.md#version-the-website).
- [Installing Kubeflow](https://www.kubeflow.org/docs/started/installing-kubeflow/)
- [Release Page](https://www.kubeflow.org/docs/releases/)
- [Distributions](https://www.kubeflow.org/docs/distributions/) and related pages underneath
- [Manifest Top](https://github.com/kubeflow/manifests)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets point to the README.md in the url

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, modified here: d61cae8

releases/handbook.md Outdated Show resolved Hide resolved
releases/handbook.md Outdated Show resolved Hide resolved
Copy link
Member

@kimwnasptd kimwnasptd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jbottum, thanks for this update! I have only one comment regarding big changes to the docs in the last minute.


*Long term re-factoring and distribution documentation*

In the long term, the Community may want to re-factor the documentation, which might include separating the user functionality from the installation and administration documentation. Additionally, each individual distribution documentation should have moved, or have a plan to move, their documentation from Kubeflow.org.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also expose that as a best practice such long term re-factoring efforts, that might be huge as well, should not happen prior to the release?

Right now we are cutting the release branches of the website before a release. So we can't have such big efforts getting merged in the last minute.

per Kimonas' suggestion.
@jbottum
Copy link
Contributor Author

jbottum commented Nov 2, 2022

Looks good @jbottum, thanks for this update! I have only one comment regarding big changes to the docs in the last minute.

I have updated the doc with language to address your concern.

@jbottum
Copy link
Contributor Author

jbottum commented Nov 3, 2022

@kimwnasptd would you please provide looks good?

@jbottum
Copy link
Contributor Author

jbottum commented Feb 21, 2023

@DomFleischmann should we consider this list as we release 1.7 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants