add a proposal of Smart Coding benchmark suite #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: boX <[email protected]>
|
The PR should further elaborate on how to implement this feature in Ianvs. |
MooreZheng
reviewed
Jul 18, 2024
There was a problem hiding this comment.
This proposal is related to #98 and there are two advices.
- Putting ianvs integration at the final stage would be risky for this project. The integration shall be started asap. As mentioned in the routine meeting, a recommended implementation from @IcyFeather233 is in https://github.com/IcyFeather233/ianvs/tree/dev, one can follow this readme to try llm single task learning and open compass.
- It is not clear how would it be related to the SIG AI project. An architecture with ianvs is needed. E.g., considering dataset, metric in TestEnv Manager. You might want to take a look at https://github.com/kubeedge/ianvs/pull/122/files for architecture example.
Signed-off-by: boX <[email protected]>
kubeedge-bot
added
the
size/L
MooreZheng
added
kind/design
Improve the architecture diagram Signed-off-by: boX <[email protected]>
# Conflicts: # docs/proposals/test-reports/Smart Coding benchmark suite Proposal.md
Signed-off-by: boX <[email protected]>
|
The logic of the subject is basically consistent with Meng Zhuo's government affairs model. |
MooreZheng
reviewed
Sep 20, 2024
|
/lgtm |
MooreZheng
requested changes
Oct 14, 2024
There was a problem hiding this comment.
There is a CI issue remains to be solved
Run pylint '/home/runner/work/ianvs/ianvs/core'
************* Module core.testcasecontroller.algorithm.paradigm.singletask_learning.singletask_learning_active_boost
core/testcasecontroller/algorithm/paradigm/singletask_learning/singletask_learning_active_boost.py:66:4: R0917
************* Module core.testenvmanager.dataset.dataset
core/testenvmanager/dataset/dataset.py:119:4: R0917: Too many positional arguments (8/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:206:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:213:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:246:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:285:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:329:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:368:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
-----------------------------------
Your code has been rated at 9.95/[10](https://github.com/kubeedge/ianvs/actions/runs/10814126756/job/30437126717?pr=120#step:5:11)
Error: Process completed with exit code 8.
MooreZheng
requested changes
Oct 26, 2024
|
/lgtm |
|
/approve |
kubeedge-bot
added
the
approved
MooreZheng
approved these changes
Oct 31, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hsj576, MooreZheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smart Coding benchmark suite: built on KubeEdge-lanvs
What type of PR is this?
/kind test
/kind design
What this PR does / why we need it:
The PR is a proposal to enhance a dataset by annotating the core code of the classic Python project, and then add project problems and App projects, etc., to finally complete the creation of the dataset and conduct test evaluation.
Which issue(s) this PR fixes:
#98
Fixes #