Add SchemaRegistry with RestProxy API #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obaydullahmhs
force-pushed
the
kf-rest
branch
2 times, most recently
from
f525c36 to
f6ade11
Compare
Signed-off-by: obaydullahmhs <[email protected]>
Signed-off-by: obaydullahmhs <[email protected]>
raihankhan
approved these changes
Jan 17, 2025
| @@ -70,6 +70,18 @@ type RestProxySpec struct { | |||
| // +optional | |||
| PodTemplate ofst.PodTemplateSpec `json:"podTemplate,omitempty"` | |||
|
|
|||
| // EnableSchemaRegistry indicates whether the REST Proxy should connect to a Schema Registry. | |||
There was a problem hiding this comment.
type SchemaRegistryRef struct {
// Name and namespace of appbinding of SchemaRegistry
// +optional
*kmapi.ObjectReference `json:",omitempty"`
// +optional
InternallyManaged bool `json:"externallyManaged,omitempty"`
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.