Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel: move from left to right #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Panel: move from left to right #5

wants to merge 2 commits into from

Conversation

vitaly-zdanevich
Copy link
Contributor

Because at the left it eats some content.

image

kuanyui and others added 2 commits March 6, 2024 10:21
@kuanyui
Update issue templates
82c0b7f
@vitaly-zdanevich
Panel: move from left to right
576d5a7 
Because at the left it eats some content.
@kuanyui
Copy link
Owner

kuanyui commented Mar 6, 2024 •
edited
Loading

This cause exactly the same problem for RTL languages users instead. (And me personally also had gotten used to left-side buttons...)

I guess adding an option (<select>, two options: right, left) in options_ui would be better.

@kuanyui
Copy link
Owner

kuanyui commented Mar 7, 2024

And... Do you truely find any page content is "eaten" by SearchEngine toolbar?

Because actually I already did some tricks to prevent <body> from being eaten:

Screenshot_20240308_003029

@kuanyui kuanyui mentioned this pull request Mar 7, 2024
Open
@vitaly-zdanevich
Copy link
Contributor Author

Currently yes, it eats some page content:
image

@kuanyui
Copy link
Owner

kuanyui commented Mar 8, 2024 via email

@vitaly-zdanevich
Copy link
Contributor Author

I found a similar extension that is not eating the content space:
image

Do you like it?

@kuanyui
Copy link
Owner

kuanyui commented Mar 8, 2024 •
edited
Loading

I found a similar extension that is not eating the content space

Do you like it?

I don't get the meaning of "eating content"... The still eats something, doesn't it?

Because the floating buttons always must occupy some space on page.

@vitaly-zdanevich
Copy link
Contributor Author

Yes, but not a useful part of the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitaly-zdanevich @kuanyui