-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global shell settings #33
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cfad1fc
--quiet is working
roboguy13 33318fb
No longer falsely claims to ignore --quiet
roboguy13 5fc073d
REPL now shows things normally, regardless of --quiet
roboguy13 455a8bb
A little bit more obvious REPL behaviour
roboguy13 662c2fd
Added a command :quiet to toggle quiet mode on and off
roboguy13 47139f0
Changed to use global IORef trick
roboguy13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,3 +14,4 @@ hermit-shell.wiki | |
.cabal-sandbox | ||
cabal.sandbox.config | ||
tests/dump/*.dump | ||
tags |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,8 @@ | |
{-# LANGUAGE DeriveDataTypeable #-} | ||
{-# LANGUAGE TypeSynonymInstances #-} | ||
{-# LANGUAGE FlexibleInstances #-} | ||
{-# LANGUAGE MultiParamTypeClasses #-} | ||
|
||
module HERMIT.API.Types where | ||
|
||
import Control.Applicative | ||
|
@@ -25,6 +27,8 @@ import HERMIT.PrettyPrinter.Common | |
import HERMIT.RemoteShell.Orphanage | ||
|
||
import Data.Coerce | ||
import Data.IORef | ||
import System.IO.Unsafe (unsafePerformIO) | ||
|
||
------------------------------------------------------------------------ | ||
|
||
|
@@ -89,15 +93,27 @@ proxyToJSON Proxy = String $ pack $ show $ typeOf (undefined :: a) | |
class FromJSON a => Response a where | ||
printResponse :: a -> IO () | ||
|
||
quietModeM :: IORef Bool | ||
quietModeM = unsafePerformIO (newIORef False) | ||
{-# NOINLINE quietModeM #-} | ||
|
||
instance Response () where | ||
printResponse () = return () | ||
|
||
instance Response String where | ||
printResponse = print | ||
printResponse str = do | ||
quietMode <- readIORef quietModeM | ||
if quietMode | ||
then return () | ||
else print str | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider refactoring lines like this into |
||
|
||
instance Response DocH where | ||
printResponse doc = | ||
let (ASCII x) = renderCode def doc in | ||
printResponse doc = do | ||
quietMode <- readIORef quietModeM | ||
if quietMode | ||
then return () | ||
else | ||
let (ASCII x) = renderCode def doc in | ||
print x | ||
|
||
------------------------------------------------------------------------ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't needed anymore, right?