Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Status added to RMC sentence. This field comes from NMEA 4.1. #142

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

JhnFlory
Copy link
Contributor

There is an update in RMC(Recommended Minimum Navigation Information) sentence. RMC sentence has extended with NavStatus field in NMEA 4.1. Parser and Sentence of RMC sentence updated according to NMEA 4.1.

(https://gpsd.gitlab.io/gpsd/NMEA.html#_rmc_recommended_minimum_navigation_information)

Copy link
Owner

@ktuukkan ktuukkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all very nicely done addition, but can you fix the enum and consider keeping the second sentence version in the tests?

@ktuukkan ktuukkan merged commit 2f804ba into ktuukkan:master Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants