New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTOR-4082 Add native image sample with config file #195

Merged

e5l merged 4 commits into main from e5l/native-image-yaml

Aug 21, 2024

Member

e5l commented Aug 12, 2024

Fix KTOR-4082 GraalVM: Native image with HOCON server sample


          KTOR-4082 Add native image sample with config file

60ce1af

e5l requested review from vnikolova and Stexxe

August 12, 2024 09:48

e5l self-assigned this

github-advanced-security bot found potential problems

View reviewed changes

native-image-server-with-yaml-config/build.gradle.kts

		@@ -0,0 +1,35 @@

		val kotlin_version: String by project

Check warning

Code scanning / detekt

Variable names should follow the naming convention set in the projects configuration. Warning

Variable names should match the pattern: [a-z][A-Za-z0-9]*

native-image-server-with-yaml-config/build.gradle.kts

		@@ -0,0 +1,35 @@

		val kotlin_version: String by project
		val logback_version: String by project

Check warning

Code scanning / detekt

Variable names should follow the naming convention set in the projects configuration. Warning

Variable names should match the pattern: [a-z][A-Za-z0-9]*

native-image-server-with-yaml-config/src/main/kotlin/example/com/Application.kt

		@@ -0,0 +1,13 @@
		package example.com

		import example.com.plugins.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

example.com.plugins.* is a wildcard import. Replace it with fully qualified imports.

native-image-server-with-yaml-config/src/main/kotlin/example/com/Application.kt

+              package example.com
+              import example.com.plugins.*
+              import io.ktor.server.application.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

io.ktor.server.application.* is a wildcard import. Replace it with fully qualified imports.

native-image-server-with-yaml-config/src/main/kotlin/example/com/plugins/Routing.kt

		@@ -0,0 +1,14 @@
		package example.com.plugins

		import io.ktor.server.application.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

io.ktor.server.application.* is a wildcard import. Replace it with fully qualified imports.

native-image-server-with-yaml-config/src/main/kotlin/example/com/plugins/Serialization.kt

		@@ -0,0 +1,18 @@
		package example.com.plugins

		import io.ktor.serialization.kotlinx.json.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

io.ktor.serialization.kotlinx.json.* is a wildcard import. Replace it with fully qualified imports.

native-image-server-with-yaml-config/src/main/kotlin/example/com/plugins/Serialization.kt

+              package example.com.plugins
+              import io.ktor.serialization.kotlinx.json.*
+              import io.ktor.server.application.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

io.ktor.server.application.* is a wildcard import. Replace it with fully qualified imports.

native-image-server-with-yaml-config/src/main/kotlin/example/com/plugins/Serialization.kt

+              import io.ktor.serialization.kotlinx.json.*
+              import io.ktor.server.application.*
+              import io.ktor.server.plugins.contentnegotiation.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

io.ktor.server.plugins.contentnegotiation.* is a wildcard import. Replace it with fully qualified imports.

native-image-server-with-yaml-config/src/main/kotlin/example/com/plugins/Serialization.kt

+              import io.ktor.serialization.kotlinx.json.*
+              import io.ktor.server.application.*
+              import io.ktor.server.plugins.contentnegotiation.*
+              import io.ktor.server.response.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

io.ktor.server.response.* is a wildcard import. Replace it with fully qualified imports.

native-image-server-with-yaml-config/src/main/kotlin/example/com/plugins/Serialization.kt

+              import io.ktor.server.application.*
+              import io.ktor.server.plugins.contentnegotiation.*
+              import io.ktor.server.response.*
+              import io.ktor.server.routing.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

io.ktor.server.routing.* is a wildcard import. Replace it with fully qualified imports.

vnikolova requested changes

View reviewed changes

Contributor

vnikolova left a comment

Looks good, just a few suggestions for the README.

native-image-server-with-yaml-config/README.md Outdated Show resolved Hide resolved

native-image-server-with-yaml-config/README.md Show resolved Hide resolved

native-image-server-with-yaml-config/README.md Show resolved Hide resolved

native-image-server-with-yaml-config/README.md Outdated Show resolved Hide resolved

e5l and others added 3 commits

August 20, 2024 17:37


          Update native-image-server-with-yaml-config/README.md

bcdce44

Co-authored-by:  Vik Nikolova <[email protected]>


          Update native-image-server-with-yaml-config/README.md

2a37653

Co-authored-by:  Vik Nikolova <[email protected]>


          Update readme and project name

87f3905

e5l requested a review from vnikolova

August 20, 2024 15:42

vnikolova approved these changes

View reviewed changes

e5l merged commit 1ac6457 into main

2 checks passed

e5l deleted the e5l/native-image-yaml branch

August 21, 2024 11:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet