Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device vector and unordered set functionalities #50

Open
wants to merge 58 commits into
base: dev
Choose a base branch
from

Conversation

kstppd
Copy link
Owner

@kstppd kstppd commented Apr 9, 2024

This PR adds the following functionalities:

  • A Device Vector class in include/splitvector/devicevec.h which is essentially a splitvector using device memory.
  • An Unordered Set implementation following the logic of Hahsinator.
    A big rename has taken place where now hashinator.h is renamed and moved to include/hashinator/hashmap/hashmap.h, to accommodate for the new include/hashinator/unordered_set/unordered_set.h

@kstppd kstppd marked this pull request as draft April 9, 2024 07:52
@kstppd kstppd marked this pull request as ready for review April 9, 2024 08:10
@markusbattarbee
Copy link
Collaborator

Having hashmap.h and unordered_set.h in subdirectories completely solo seems a bit daft to me.

@kstppd
Copy link
Owner Author

kstppd commented Apr 9, 2024

Having hashmap.h and unordered_set.h in subdirectories completely solo seems a bit daft to me.

@markusbattarbee I agree. I pushed again with them one dir up.

@markusbattarbee
Copy link
Collaborator

So here's food for thought.
Currently the device vector is a completely separate entity. There is no base class, no class inheritance, and that means that any hash map or set functionality (or splitvector methods such as the new looping reductions) which take splitvector as an input cannot use devicevectors.

Would it make sense to have a basevector class (which also has any shared methods), and have splitvectors and devicevectors inherit that? Then perhaps the methods could build on that class. Or, alternatively, have devicevector inherit splitvector and just override any methods which are not wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants