-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizations and Arch Agnostic Hashinator #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Less device-blocking operations
…up debug prints in hashmap unit test
…city and _size to Splitvec's optimize methods
…warpAccessors is behind an ifdef
… the current size
NOMAD Hackathon
`is_pod` is deprecated in C++20. By removing `is_pod` with `is_trivially_contructable` more types can used via the optimized copy. For destruction `is_nothrow_destructible` is used to destruct types if possible.
- fix missing include - add support for any HIP compiler by using `__HIP__` instead of `__HIP_PLATFORM_HCC___` - fix hard coded warp size for AMD GPUs. The warp size depends on the architecture.
remove deprecated `is_pod`
support for any HIP compiler
…so some hashers.h is now split into 3 files
Delete optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a massive one and comes with many updates and upgrades
Fomating and Style updates
Structural updates
Performance upgrades