Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.2.0 #25

Merged
merged 8 commits into from
May 31, 2024
Merged

Release v1.2.0 #25

merged 8 commits into from
May 31, 2024

Conversation

dipankardas011
Copy link
Member

Tasks description

Related Issues

Solution

Tasks

  • milestones or sub-task which needs to be coverted

Note to reviewers

@github-actions github-actions bot added the go label May 30, 2024
@dipankardas011
Copy link
Member Author

dipankardas011 commented May 30, 2024

explore all the fields in *cli.Command

just like deprication

also move the logger to cli repo

@dipankardas011
Copy link
Member Author

BUG

image

@dipankardas011
Copy link
Member Author

Even after installing ksctl specific apps it is failing

Some context ss

image

Some context input

image

@dipankardas011
Copy link
Member Author

Even after installing ksctl specific apps it is failing

Some context ss

image

Some context input

image

Resolved

@dipankardas011
Copy link
Member Author

bug
Mongodb in cli not working but when tested on ksctl core it is working as expected

image

@dipankardas011
Copy link
Member Author

bug Mongodb in cli not working but when tested on ksctl core it is working as expected

image

Resolved

Important

because the ctx( USERID -> should be a single word not a path)

@dipankardas011 dipankardas011 force-pushed the release-v1_2_0 branch 17 times, most recently from a2660d8 to 634f27b Compare May 31, 2024 16:37
Signed-off-by: Dipankar Das <[email protected]>

feat: made the changes

Signed-off-by: Dipankar Das <[email protected]>

improvements to makefile

Signed-off-by: Dipankar Das <[email protected]>

some improvements in depricated things

Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>

feat(mock-test): added mongodb external store based storage in mock

Signed-off-by: Dipankar Das <[email protected]>

added the fake flag to the cli

Signed-off-by: Dipankar Das <[email protected]>

fix: mock and cli

Signed-off-by: Dipankar Das <[email protected]>
and other storage driver using it works

Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>

modified the mock test

Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
@dipankardas011
Copy link
Member Author

dipankardas011 commented May 31, 2024

check if we don't provide bootstrap then does ksctl core automatically chooses it?
Context: add-nodes

@dipankardas011
Copy link
Member Author

check if we don't provide bootstrap then does ksctl core automatically chooses it? Context: add-nodes

No it doesn't

Copy link
Member Author

@dipankardas011 dipankardas011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/cmd/version.go Show resolved Hide resolved
Signed-off-by: Dipankar Das <[email protected]>
@dipankardas011 dipankardas011 merged commit b5cfe34 into main May 31, 2024
10 checks passed
@dipankardas011 dipankardas011 deleted the release-v1_2_0 branch August 2, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Release]: v1.2.0
1 participant