fixed the nil pointer issue for --approve -> --yes

Signed-off-by: Dipankar Das <[email protected]>
ksctl · May 31, 2024 · 7b2c7e8 · 7b2c7e8
1 parent 838af7f
commit 7b2c7e8
Show file tree

Hide file tree

Showing 11 changed files with 849 additions and 414 deletions.
diff --git a/.github/workflows/test-mock.bkp.yml b/.github/workflows/test-mock.bkp.yml
diff --git a/.github/workflows/test-mock.yml b/.github/workflows/test-mock.yml
@@ -21,7 +21,8 @@ jobs:
   ksctl-cli-windows:
     strategy:
       matrix:
-        os: [macos-latest, ubuntu-latest, windows-latest]
+        os: [macos-latest, ubuntu-latest]
+        # os: [macos-latest, ubuntu-latest, windows-latest]
 
     if: |
       (
@@ -36,38 +37,40 @@ jobs:
       KSCTL_FAKE_FLAG_ENABLED: "1"
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: 1.21.0
-
-      - name: build ksctl windows
-        if: ${{ matrix.os == 'windows-latest' }}
-        run: |
-          cd .\scripts
-          .\builder.ps1
-          cd C:\Users\runneradmin\AppData\Local\ksctl
-          .\ksctl.exe version
-
-          echo "KSCTL_BIN=.\C:\Users\runneradmin\AppData\Local\ksctl\ksctl.exe" >> ${GITHUB_ENV}
+          go-version: 1.22.3
+
+      # - name: build ksctl windows
+      #   if: ${{ matrix.os == 'windows-latest' }}
+      #   run: |
+      #     cd .\scripts
+      #     .\builder.ps1
+      #     cd C:\Users\runneradmin\AppData\Local\ksctl
+      #     echo "KSCTL_BIN=.\C:\Users\runneradmin\AppData\Local\ksctl\ksctl.exe" >> ${GITHUB_ENV}
+      #     ${{ env.KSCTL_BIN }} version
+      #
 
       - name: build ksctl linux
         if: ${{ matrix.os == 'ubuntu-latest' }}
         run: |
+          set -x
           make install_linux
-          ksctl version
-
           echo "KSCTL_BIN=ksctl" >> ${GITHUB_ENV}
+          echo "cscds: $KSCTL_BIN"
+          $KSCTL_BIN version
 
       - name: build ksctl macos
         if: ${{ matrix.os == 'macos-latest' }}
         run: |
+          set -x
           make install_macos_intel
-          ksctl version
-
           echo "KSCTL_BIN=ksctl" >> ${GITHUB_ENV}
+          echo "cscds: $KSCTL_BIN"
+          $KSCTL_BIN version
 
 
       - name: civo create