-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving folder structure #33
base: mvp_demo
Are you sure you want to change the base?
Conversation
Reusable components (like drop down, bar chart etc) should be a part of the component folder, also App Layout should not be a part of Component folder. |
App Layout is a generic component and independent of application logic, so I thought it move into components folder. However, if you think we should move App Layout out of components folder, no issue from my side. Just let me know your opinion. And regarding RunExperiment and Regular Section, Could you please provide more context or specific details about this. |
can we have a layouts folder inside of components and put app layout in that. Planning a standard folder structure that we can follow |
13ffce1
to
782a598
Compare
782a598
to
1186b8f
Compare
Hi @ppadti the ui is not able to pick up Kruize port number for me and hence the List experiment api is not working. The dropdown menu for usecase selection showing Remote and Local option where as its supposed to show only Remote option as per latest (Kruize-ui , mvp_demo) branch. Can u check once |
Sure, I will check that. |
This PR aims to restructure the project folder to enhance the code organization. The changes includes moving components to dedicated directories and updatng imports accordingly.