Adding perf script for galaxies #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shruthi <[email protected]>
kusumachalasani
requested changes
Apr 1, 2021
| # input:galaxies image to be used and JVM arguments if any | ||
| # output:Create network bridge "kruize-network" and run galaxies application container on the same network | ||
| function run_galaxies() { | ||
| GALAXIES_IMAGE=$1 |
There was a problem hiding this comment.
Variable for JVM arguments is missing in this function.
| svc_apis=($(oc status --namespace=${NAMESPACE} | grep "galaxies" | grep port | cut -d " " -f1 | cut -d "/" -f3)) | ||
| for svc_api in "${svc_apis[@]}" | ||
| do | ||
| RESULT_LOG=${RESULTS_DIR_P}/wrk-${svc_api}-${TYPE}-${run}.log |
There was a problem hiding this comment.
Can you also parse the percentile details of hyperfoil/wrk2
Add --latency option to wrk2 command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shruthi [email protected]