Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix to promote-release #427

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Bug fix to promote-release #427

merged 1 commit into from
Nov 22, 2024

Conversation

k-wall
Copy link
Contributor

@k-wall k-wall commented Nov 22, 2024

Type of change

Select the type of your PR

  • Bugfix

Description

Promote release (get heads) failed like this:

https://github.com/kroxylicious/kroxylicious-junit5-extension/actions/runs/11970938391/job/33374714845#step:7:1

fatal: ambiguous argument 'release-work-0.10.0-64c4f483a8162493f2b60141^^': unknown revision or path not in the working tree.

The issue is the branch doesn't exist as a working branch. It needs to be qualified with the remote name (origin). I don't understand how this was working before.

Additional Context

Why are you making this pull request?

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

Promote release failed like this:

fatal: ambiguous argument 'release-work-0.10.0-64c4f483a8162493f2b60141^^': unknown revision or path not in the working tree.

The issue is the branch doesn't exist as a working branch.  It needs to be qualified with the remote



Signed-off-by: Keith Wall <[email protected]>
@k-wall k-wall requested a review from franvila November 22, 2024 11:01
Copy link
Contributor

@franvila franvila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-wall k-wall merged commit 75c355d into main Nov 22, 2024
2 checks passed
@k-wall k-wall deleted the k-wall-patch-2 branch November 22, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants