Release promotion - correct check/status interaction (#429)

* Release promotion - correct check/status interaction Why: the SHA passed for the check/status interactions was incorrect and the HTTP method used for the initial observation was wrong.
kroxylicious · Nov 22, 2024 · 3d7676a · 3d7676a
1 parent 75c355d
commit 3d7676a
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/.github/workflows/promote_release.yaml b/.github/workflows/promote_release.yaml
@@ -105,6 +105,9 @@ jobs:
 
       - name: 'Get heads'
         run: |
+          # Get PR's ref.
+          echo "PR_REF=$(git rev-list -n 1 origin/${PR_BRANCH})" >> $GITHUB_ENV
+
           # Get main's current head
           echo "MAIN_HEAD=$(git rev-list -n 1 main)" >> $GITHUB_ENV
 
@@ -127,10 +130,10 @@ jobs:
         env:
           GH_TOKEN: ${{ secrets.KROXYLICIOUS_RELEASE_TOKEN }}
         run: |
-          STATUS=$(gh api --method POST \
+          STATUS=$(gh api \
               -H "Accept: application/vnd.github+json" \
               -H "X-GitHub-Api-Version: 2022-11-28" \
-              /repos/${{ github.repository }}/commits/${PR_MAIN_REF}/check-runs \
+              /repos/${{ github.repository }}/commits/${PR_REF}/check-runs \
               | jq --exit-status -r '.check_runs[] | select(.name=="build") | .status + "/" + .conclusion')
 
           if [[ ${STATUS} != "completed/success" ]]; then
@@ -169,7 +172,7 @@ jobs:
           gh api --method POST \
                  -H "Accept: application/vnd.github+json" \
                  -H "X-GitHub-Api-Version: 2022-11-28" \
-                 /repos/${{ github.repository }}/statuses/${PR_MAIN_REF} \
+                 /repos/${{ github.repository }}/statuses/${PR_REF} \
                  -f "state=success" \
                  -f "description=Release to Maven Central is complete" \
                  -f "context=maven-central"