Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build step parsing that includes newlines #344

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Fix build step parsing that includes newlines #344

merged 2 commits into from
Apr 10, 2024

Conversation

michalszelagsonos
Copy link
Contributor

This PR fixes #341 where build steps that have newlines that match the escape regex are not quoted correctly.

The fix is to use a negative look ahead in the escape regex to make sure the string doesn't contain new lines. If it does, run it through the usual escape logic which produces correct results.

@kronenthaler kronenthaler changed the base branch from master to fix/build-step-cleaning-regex April 10, 2024 07:51
@kronenthaler kronenthaler merged commit 4a40799 into kronenthaler:fix/build-step-cleaning-regex Apr 10, 2024
4 of 5 checks passed
kronenthaler added a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Build steps that have shell commands lose formatting when project is saved
2 participants