fix: add escaping for backslash \

kronenthaler · Jan 16, 2017 · 4e8796c · 4e8796c
1 parent 90ce0b6
commit 4e8796c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/pbxproj/PBXGenericObject.py b/pbxproj/PBXGenericObject.py
@@ -171,10 +171,11 @@ def _generate_id(cls):
     @classmethod
     def _escape(cls, item):
         if item.__len__() == 0 or re.match(cls._VALID_KEY_REGEX, item).group(0) != item:
-            escaped = item.replace(u'\n', u'\\n')\
+            escaped = item.replace(u'\\', u'\\\\')\
+                .replace(u'\n', u'\\n')\
                 .replace(u'\"', u'\\"')\
                 .replace(u'\0', u'\\0')\
-                .replace(u'\'',u'\\\'')\
-                .replace(u'\t',u'\\\t')
+                .replace(u'\'', u'\\\'')\
+                .replace(u'\t', u'\\\t')
             return u'"{0}"'.format(escaped)
         return item
diff --git a/pbxproj/__init__.py b/pbxproj/__init__.py
@@ -27,4 +27,4 @@
 from pbxproj.XcodeProject import XcodeProject
 from pbxproj.pbxsections import *
 
-__version__ = '2.0.1'
+__version__ = '2.0.2'
diff --git a/setup.py b/setup.py
@@ -45,7 +45,7 @@ def run_tests(self):
         ]
       },
       url="http://github.com/kronenthaler/mod-pbxproj",
-      version='2.0.1',
+      version='2.0.2',
       license='MIT License',
       install_requires=['openstep_parser', 'docopt'],
       packages=find_packages(exclude=['tests']),

diff --git a/tests/TestPBXGenericObject.py b/tests/TestPBXGenericObject.py
@@ -33,6 +33,7 @@ def testEscapeItem(self):
         self.assertEqual(PBXGenericObject._escape("a.valid_id."), "a.valid_id.")
         self.assertEqual(PBXGenericObject._escape("a-invalid-id"), '"a-invalid-id"')
         self.assertEqual(PBXGenericObject._escape("<group>"), '"<group>"')
+        self.assertEqual(PBXGenericObject._escape("script \\ continuation"), '"script \\\\ continuation"')
 
     def testPrintObject(self):
         obj = {"a": "varA", "b": [1, 2, 3], "c": {"c1": "FDDF6A571C68E5B100D7A645"}}