Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(crypto): optimize TwoAdicFri #555

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

chokobole
Copy link
Contributor

@chokobole chokobole commented Oct 31, 2024

Description

This optimizes TwoAdicFri::CreateOpeningProof() with these 2.

  • parallelize copy.
  • merge ReverseMatrixIndexBits() into one single parallel loop.

In addition, it adopts Plonky3's accelerated x86 simd operations for PackedBabyBear and PackedKoalaBear.

- parallelize copy.
- merge `ReverseMatrixIndexBits()` into one single parallel loop.
Copy link
Contributor

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole force-pushed the perf/optimize-create-opening-proof branch from 2c5ee16 to 59c3800 Compare October 31, 2024 07:04
@chokobole chokobole changed the title perf(crypto): optimize TwoAdicFri::CreateOpeningProof() perf(crypto): optimize TwoAdicFri Oct 31, 2024
@chokobole chokobole force-pushed the perf/optimize-create-opening-proof branch from 59c3800 to 2e0f7f0 Compare October 31, 2024 09:26
Copy link
Contributor

@batzor batzor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit d0ae6c9 into main Nov 4, 2024
5 checks passed
@chokobole chokobole deleted the perf/optimize-create-opening-proof branch November 4, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants