chore: update benchmarks #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashjeong
force-pushed
the
chore/update-benchmarks
branch
7 times, most recently
from
43f1c61
to
c953dfc
Compare
ashjeong
requested review from
chokobole,
batzor,
dongchangYoo,
TomTaehoonKim and
GideokKim
|
Could you change |
ashjeong
force-pushed
the
chore/update-benchmarks
branch
2 times, most recently
from
927f393
to
64b03f6
Compare
dongchangYoo
requested changes
Oct 21, 2024
tachyon/crypto/commitments/merkle_tree/field_merkle_tree/field_merkle_tree.h
Outdated
Show resolved
Hide resolved
ashjeong
force-pushed
the
chore/update-benchmarks
branch
from
64b03f6
to
c7b04e1
Compare
ashjeong
force-pushed
the
chore/update-benchmarks
branch
3 times, most recently
from
19e7ca3
to
fc90048
Compare
ashjeong
force-pushed
the
chore/update-benchmarks
branch
from
fc90048
to
c0a4a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all benchmarks as new flags were added from #549 and a dynamic scheduler was introduced(See here).
The most significant decrease in time occurred for FRI on Linux. FRI on Tachyon has changed from being 1.23x faster than Plonky3 to now being 1.57x faster.
Many previous benchmarks were not updated after significant changes to its benchmark or code logic. FRI benchmark for Mac is one such example, where the
round_numflag of 4 was added, but never re-benchmarked for Mac. As such, similar signifcant increases of time for all parties in the new benchmark data may indicate the previous benchmark was deprecated.