perf: reduce redundant zero initializations #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batzor
force-pushed
the
perf/reduce-redundant-zero-initializations
branch
from
2c3004b
to
cfa0e10
Compare
batzor
force-pushed
the
perf/reduce-redundant-zero-initializations
branch
3 times, most recently
from
4763f40
to
a5785f3
Compare
batzor
changed the title
batzor
requested review from
chokobole,
dongchangYoo,
TomTaehoonKim and
ashjeong
ashjeong
reviewed
Sep 30, 2024
chokobole
reviewed
Oct 2, 2024
tachyon/math/finite_fields/generator/prime_field_generator/prime_field_x86.h.tpl
Outdated
Show resolved
Hide resolved
batzor
force-pushed
the
perf/reduce-redundant-zero-initializations
branch
5 times, most recently
from
f014252
to
813b0ad
Compare
ashjeong
approved these changes
Oct 7, 2024
chokobole
reviewed
Oct 7, 2024
tachyon/math/polynomials/multivariate/multilinear_dense_evaluations.h
Outdated
Show resolved
Hide resolved
tachyon/math/polynomials/univariate/univariate_polynomial_ops.h
Outdated
Show resolved
Hide resolved
vendors/circom/circomlib/circuit/quadratic_arithmetic_program.h
Outdated
Show resolved
Hide resolved
tachyon/zk/r1cs/constraint_system/quadratic_arithmetic_program.h
Outdated
Show resolved
Hide resolved
batzor
force-pushed
the
perf/reduce-redundant-zero-initializations
branch
3 times, most recently
from
262d3c3
to
086536b
Compare
chokobole
reviewed
Oct 8, 2024
batzor
force-pushed
the
perf/reduce-redundant-zero-initializations
branch
from
086536b
to
e344ce2
Compare
batzor
force-pushed
the
perf/reduce-redundant-zero-initializations
branch
from
e344ce2
to
90452b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
BigIntandFielddefault constructor to be non-initializing, which makes it possible to initialize large vectors in multiple threads.