perf: integrate icicle mmcs #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GideokKim
force-pushed
the
perf/integrate-icicle-mmcs
branch
13 times, most recently
from
1eb7754
to
1a557d2
Compare
chokobole
force-pushed
the
perf/integrate-icicle-mmcs
branch
from
1a557d2
to
db6537c
Compare
chokobole
requested review from
ashjeong,
batzor,
chokobole,
dongchangYoo and
TomTaehoonKim
and removed request for
ashjeong,
batzor and
chokobole
chokobole
force-pushed
the
perf/integrate-icicle-mmcs
branch
from
db6537c
to
6273e66
Compare
ashjeong
reviewed
Oct 2, 2024
tachyon/c/zk/air/sp1/baby_bear_poseidon2_two_adic_fri_type_traits.h
Outdated
Show resolved
Hide resolved
GideokKim
force-pushed
the
perf/integrate-icicle-mmcs
branch
from
08fc1de
to
245c278
Compare
This is needed to retrieve `Poseidon2Params` from those.
…utation` This is needed to retrieve `Rate` from `PaddingFreeSponge` when configuring `Poseidon2Icicle`.
Since cpplint 2.0.0, indent inspection has been added but still contains a bug. This commit filters out the indent inspection to avoid issues caused by a bug. See cpplint/cpplint#235
GideokKim
force-pushed
the
perf/integrate-icicle-mmcs
branch
from
245c278
to
06601b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates icicle MMCS for improved performance.
The key changes are the following:
Poseidon2Vendoris introduced to switch vendor betweenPlonky3andHorizen.Poseidon2Vendoris merged intoPoseidon2Paramsto simplify a lot of configuration details.v2.8.0with a single typco commit.ICICLEPoseidon2andICICLEMMCSare introduced.