Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac: refactor two adic fri pcs #526

Merged
merged 21 commits into from
Aug 30, 2024
Merged

refac: refactor two adic fri pcs #526

merged 21 commits into from
Aug 30, 2024

Conversation

chokobole
Copy link
Contributor

Description

This PR refactors TwoAdicFriPCS.

@chokobole chokobole force-pushed the refac/refactor-two-adic-fri-pcs branch from 3f5df47 to cc09ecb Compare August 28, 2024 07:47
GideokKim
GideokKim approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@GideokKim GideokKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomTaehoonKim
TomTaehoonKim approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

batzor
batzor approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@batzor batzor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole
fix(crypto): fix type inference correctly
3edba86
@chokobole
refac(crypto): rename Pcs to PCS
2a51856
@chokobole
refac(crypto): change template type of BatchOpening
33ed7f1
@chokobole
refac(crypto): change template type of CommitPhaseResult
c7c5f83
@chokobole
refac(crypto): use base::CreateVector
696e5fd
@chokobole
refac(crypto): move logging final eval to closer where it is used
cac0aeb
@chokobole
refac(crypto): change template type of TwoAdicFriProof
b846c54
@chokobole
refac: rename TwoAdicFriConfig to FriConfig
8486867 
See https://github.com/Plonky3/Plonky3/blob/eeb4e37/fri/src/config.rs.
@chokobole
refac: move zk/air/plonky3 files to crypto
a3a3240
@chokobole
refac: remove Domain template from TwoAdicFriPCS
6731d54
@chokobole
refac(crypto): rename two_adic_fri_verifier.h to verify.h
31ba5d9 
See https://github.com/Plonky3/Plonky3/blob/eeb4e37/fri/src/verifier.rs.
@chokobole
refac(crypto): rename two_adic_fri_prover.h to prove.h
f25c6bf 
See https://github.com/Plonky3/Plonky3/blob/eeb4e37/fri/src/prover.rs.
@chokobole
refac(crypto): rename FRIXXX to SimpleFRIXXX
c2ba345
@chokobole
refac(crypto): rename TwoAdicFriProof to FriProof
799cf3f 
See https://github.com/Plonky3/Plonky3/blob/eeb4e37/fri/src/proof.rs
@chokobole
refac!: rename TwoAdicFriPcs to TwoAdicFRI for consistency
cd5b29b 
BREAKING CHANGE: C API and Rust bindings have been updated to reflect
this change.
@chokobole
refac: reanme Fri to FRI for consistency
a75038c
@chokobole chokobole force-pushed the refac/refactor-two-adic-fri-pcs branch from 5c2c749 to a75038c Compare August 30, 2024 01:52
TomTaehoonKim
TomTaehoonKim approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dongchangYoo
dongchangYoo approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashjeong
ashjeong approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit 2116204 into main Aug 30, 2024
7 checks passed
@chokobole chokobole deleted the refac/refactor-two-adic-fri-pcs branch August 30, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batzor batzor batzor approved these changes

@dongchangYoo dongchangYoo dongchangYoo approved these changes

@TomTaehoonKim TomTaehoonKim TomTaehoonKim approved these changes

@GideokKim GideokKim GideokKim approved these changes

@ashjeong ashjeong ashjeong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chokobole @batzor @dongchangYoo @TomTaehoonKim @GideokKim @ashjeong