test(benchmark): add baby bear poseidon2 benchmark #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashjeong
requested review from
chokobole,
batzor,
dongchangYoo,
TomTaehoonKim and
GideokKim
|
please add the scope benchmark to all the commits. |
ashjeong
changed the title
ashjeong
force-pushed
the
test/add-poseidon2-benchmark
branch
from
109ae21
to
843f3f4
Compare
chokobole
reviewed
Aug 13, 2024
chokobole
reviewed
Aug 13, 2024
ashjeong
force-pushed
the
test/add-poseidon2-benchmark
branch
from
843f3f4
to
bfcd3e5
Compare
ashjeong
force-pushed
the
test/add-poseidon2-benchmark
branch
3 times, most recently
from
98facc0
to
e646b19
Compare
batzor
force-pushed
the
test/add-poseidon2-benchmark
branch
from
e646b19
to
940c74c
Compare
ashjeong
force-pushed
the
test/add-poseidon2-benchmark
branch
3 times, most recently
from
bcdf927
to
0be182b
Compare
chokobole
reviewed
Aug 14, 2024
ashjeong
force-pushed
the
test/add-poseidon2-benchmark
branch
from
0be182b
to
ccefa39
Compare
ashjeong
force-pushed
the
test/add-poseidon2-benchmark
branch
from
ccefa39
to
7843d32
Compare
chokobole
reviewed
Aug 14, 2024
ashjeong
force-pushed
the
test/add-poseidon2-benchmark
branch
from
7843d32
to
23b439b
Compare
Note that Poseidon2 permutations are now run 100 times to make the difference in results more visible. Authored by @chokobole, fixed by @ashjeong
ashjeong
force-pushed
the
test/add-poseidon2-benchmark
branch
from
23b439b
to
67d1c51
Compare
dongchangYoo
approved these changes
Aug 14, 2024
batzor
reviewed
Aug 14, 2024
I do agree with you that this would be better shortened in the way you mentioned; however the photos are named in this way across all other benchmark photos and the standard becomes convoluted especially with the fft benchmark folder which has |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whereas all other benchmarks display all vendors on the same graph, Plonky3 and Horizen compute values with a different internal matrix, requiring them to be compared with Tachyon separately.