Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add FFTBatch benchmark #515

Merged
merged 9 commits into from
Aug 19, 2024
Merged

feat: add FFTBatch benchmark #515

merged 9 commits into from
Aug 19, 2024

Conversation

batzor
Copy link
Contributor

@batzor batzor commented Aug 9, 2024 •
edited
Loading

Description

This PR adds FFTBatch benchmark of Tachyon and Plonky3.

@batzor batzor changed the title docs(bench): introduce FFTBatch benchmark feat: add FFTBatch benchmark Aug 9, 2024
@chokobole
Copy link
Contributor

docs(bench): introduce FFTBatch benchmark should be typed with test

chokobole
chokobole reviewed Aug 9, 2024
View reviewed changes
benchmark/fft_batch/benchmark_runner.h Outdated Show resolved Hide resolved
benchmark/fft_batch/benchmark_runner.h Outdated Show resolved Hide resolved
chokobole
chokobole reviewed Aug 9, 2024
View reviewed changes
benchmark/fft_batch/config.cc Outdated Show resolved Hide resolved
benchmark/fft_batch/config.cc Outdated Show resolved Hide resolved
benchmark/fft_batch/config.h Outdated Show resolved Hide resolved
@batzor batzor force-pushed the feat/add-fft-batch-benchmark branch 4 times, most recently from 9cdd601 to 0e17e9d Compare August 9, 2024 11:15
chokobole
chokobole reviewed Aug 9, 2024
View reviewed changes
benchmark/fft_batch/benchmark.cc Outdated Show resolved Hide resolved
benchmark/fft_batch/config.h Outdated Show resolved Hide resolved
benchmark/fft_batch/config.h Outdated Show resolved Hide resolved
benchmark/fft_batch/config.cc Outdated Show resolved Hide resolved
benchmark/fft_batch/config.cc Outdated Show resolved Hide resolved
benchmark/fft_batch/config.cc Outdated Show resolved Hide resolved
benchmark/fft_batch/config.cc Outdated Show resolved Hide resolved
benchmark/fft_batch/benchmark.cc Outdated Show resolved Hide resolved
benchmark/fft_batch/plonky3/src/lib.rs Outdated Show resolved Hide resolved
benchmark/fft_batch/benchmark_runner.h Outdated Show resolved Hide resolved
@batzor batzor marked this pull request as draft August 10, 2024 07:13
@batzor batzor force-pushed the feat/add-fft-batch-benchmark branch from c7eec5e to 2b869e9 Compare August 12, 2024 10:34
@chokobole chokobole mentioned this pull request Aug 12, 2024
Merged
@batzor batzor force-pushed the feat/add-fft-batch-benchmark branch 7 times, most recently from b9be430 to 2d3611e Compare August 13, 2024 09:27
@batzor batzor marked this pull request as ready for review August 13, 2024 09:27
@batzor batzor force-pushed the feat/add-fft-batch-benchmark branch from 2d3611e to 3c047e3 Compare August 13, 2024 10:08
@chokobole
Copy link
Contributor

I think

chokobole
chokobole reviewed Aug 13, 2024
View reviewed changes
benchmark/fft/fft_benchmark.cc Show resolved Hide resolved
benchmark/fft/fft_benchmark.cc Outdated Show resolved Hide resolved
benchmark/msm/msm_runner.h Outdated Show resolved Hide resolved
benchmark/msm/msm_runner.h Show resolved Hide resolved
benchmark/simple_reporter.h Outdated Show resolved Hide resolved
benchmark/poseidon2/poseidon2_config.h Outdated Show resolved Hide resolved
benchmark/poseidon2/poseidon2_benchmark.cc Outdated Show resolved Hide resolved
benchmark/msm/msm_benchmark.cc Outdated Show resolved Hide resolved
benchmark/msm/msm_config.h Outdated Show resolved Hide resolved
benchmark/field_type.h Outdated Show resolved Hide resolved
GideokKim
GideokKim approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@GideokKim GideokKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batzor batzor force-pushed the feat/add-fft-batch-benchmark branch from c116f77 to 47856fe Compare August 15, 2024 13:27
dongchangYoo
dongchangYoo approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batzor batzor force-pushed the feat/add-fft-batch-benchmark branch 2 times, most recently from 0f95a6f to 41510b7 Compare August 16, 2024 08:44
ashjeong
ashjeong reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

94bae27
folders -> folder

benchmark/poseidon2/poseidon2_benchmark.cc Outdated Show resolved Hide resolved
benchmark/poseidon2/poseidon2_benchmark.cc Outdated Show resolved Hide resolved
benchmark/fft_batch/README.md Outdated Show resolved Hide resolved
benchmark/fft_batch/README.md Outdated Show resolved Hide resolved
@batzor batzor force-pushed the feat/add-fft-batch-benchmark branch 5 times, most recently from dd033f2 to 9de7ad7 Compare August 16, 2024 10:40
ashjeong
ashjeong approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batzor batzor force-pushed the feat/add-fft-batch-benchmark branch 2 times, most recently from 7f90689 to 81cff39 Compare August 19, 2024 01:34
chokobole
chokobole reviewed Aug 19, 2024
View reviewed changes
benchmark/config.h Outdated Show resolved Hide resolved
@batzor batzor force-pushed the feat/add-fft-batch-benchmark branch from 81cff39 to ab9b4af Compare August 19, 2024 03:57
chokobole
chokobole approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chokobole
chokobole approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit 12df55d into main Aug 19, 2024
7 checks passed
@chokobole chokobole deleted the feat/add-fft-batch-benchmark branch August 19, 2024 04:57
@chokobole chokobole mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chokobole chokobole chokobole approved these changes

@dongchangYoo dongchangYoo dongchangYoo approved these changes

@TomTaehoonKim TomTaehoonKim TomTaehoonKim approved these changes

@GideokKim GideokKim GideokKim approved these changes

@ashjeong ashjeong ashjeong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@batzor @chokobole @dongchangYoo @TomTaehoonKim @GideokKim @ashjeong