Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add openmp flags to goldilocks #513

Merged
merged 2 commits into from
Aug 9, 2024
Merged

build: add openmp flags to goldilocks #513

merged 2 commits into from
Aug 9, 2024

Conversation

batzor
Copy link
Contributor

@batzor batzor commented Aug 9, 2024

Description

This PR adds openmp support for goldilocks.

Previously, we used to have a warning when building with openmp.

INFO: From Compiling src/goldilocks_base_field.cpp:
external/goldilocks/src/goldilocks_base_field.cpp:72: warning: ignoring '#pragma omp parallel' [-Wunknown-pragmas]
   72 | #pragma omp parallel for num_threads(num_threads_copy)
      | 
external/goldilocks/src/goldilocks_base_field.cpp:93: warning: ignoring '#pragma omp parallel' [-Wunknown-pragmas]
   93 | #pragma omp parallel for num_threads(num_threads_copy)
      |

chokobole
chokobole approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dongchangYoo
dongchangYoo approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batzor batzor changed the title Build/add openmp flags to goldilocks build: add openmp flags to goldilocks Aug 9, 2024
ashjeong
ashjeong approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomTaehoonKim
TomTaehoonKim approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GideokKim
GideokKim approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@GideokKim GideokKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit ec6c6f8 into main Aug 9, 2024
7 checks passed
@chokobole chokobole deleted the build/add-openmp-flags-to-goldilocks branch August 9, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chokobole chokobole chokobole approved these changes

@dongchangYoo dongchangYoo dongchangYoo approved these changes

@TomTaehoonKim TomTaehoonKim TomTaehoonKim approved these changes

@GideokKim GideokKim GideokKim approved these changes

@ashjeong ashjeong ashjeong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@batzor @chokobole @dongchangYoo @TomTaehoonKim @GideokKim @ashjeong